Multi-image generation CI tests #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohit Deopujari <[email protected]>
Signed-off-by: Mohit Deopujari <[email protected]>
Signed-off-by: Mohit Deopujari <[email protected]>
Signed-off-by: Mohit Deopujari <[email protected]>
MohitIntel
requested review from
adobrzyn,
afierka-intel,
kzawora-intel,
mgawarkiewicz-intel,
michalkuligowski,
mswiniarsk,
vivekgoe and
xuechendi
as code owners
✅ CI PassedAll checks passed successfully against the following vllm commit: |
|
@xuechendi Could you review this PR? single image test doesn't cover test coverage for the sliding_window since seq_len is smaller than 1024(sliding_window size), so we are adding this. I realized that test was added to 27b model, if you want to keep it small model(4b), we can do that as well. Let us know. |
|
/run-gaudi-tests |
|
/run-gaudi-tests |
✅ CI PassedAll checks passed successfully against the following vllm commit: |
|
@xuechendi can this be merged? |
michalkuligowski
approved these changes
Oct 16, 2025
hlahkar
pushed a commit
to hlahkar/vllm-gaudi
that referenced
this pull request
Oct 24, 2025
### Test with multimodal-support for multiple images - Current CI test for gemma3 only runs single image per prompt and its input seq_len is less than current sliding_window length (1024). - This new test is designed such that the total input length exceeds the default sliding_window length (1024) to help validate the sliding_window mechanism is actually working or not. --------- Signed-off-by: Mohit Deopujari <[email protected]> Co-authored-by: Michał Kuligowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test with multimodal-support for multiple images